Throw Error When Using Unsupported Linux ARM #14616

shbenzer · 2024-10-17T21:50:38Z

User description

Added code for Issue #13793 in Selenium Manager

Description

Selenium Manager Java should now throw an error if using unsupported Linux ARM architecture

Motivation and Context

Issue #13793

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

I have read the contributing document.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

PR Type

Bug fix

Description

Added error handling in SeleniumManager to throw an exception when an unsupported Linux ARM64 architecture is detected.
Ensures that users are informed about the lack of support for Linux ARM64 in Selenium Manager.

Changes walkthrough 📝

Relevant files

Error handling

SeleniumManager.java `Add error handling for unsupported Linux ARM architecture` java/src/org/openqa/selenium/manager/SeleniumManager.java Added a check for Linux ARM architecture. Throws a `WebDriverException` if ARM64 architecture is detected. Ensures compatibility warning for unsupported architectures.	+4/-0

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

qodo-merge-pro · 2024-10-17T21:50:59Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Error Message Clarity The error message for unsupported Linux ARM architecture could be more specific and informative. Consider providing more details about supported architectures or alternative solutions. Architecture Detection The current check for ARM architecture using `System.getProperty("os.arch").contains("arm")` might be too broad. Consider using a more precise method to detect specifically ARM64 architecture.

qodo-merge-pro · 2024-10-17T21:51:17Z

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Enhancement	Improve architecture detection specificity for more accurate unsupported platform identification Consider using a more specific check for ARM64 architecture instead of a general ARM check. This allows for potential future support of other ARM variants. java/src/org/openqa/selenium/manager/SeleniumManager.java [197-201] -if (System.getProperty("os.arch").contains("arm")) { - throw new WebDriverException("Linux ARM64= is not supported by Selenium Manager"); +if (System.getProperty("os.arch").equals("aarch64")) { + throw new WebDriverException("Linux ARM64 is not supported by Selenium Manager"); } else { folder = "linux"; } Apply this suggestion Suggestion importance[1-10]: 8 Why: The suggestion improves the specificity of the architecture check by targeting "aarch64" directly, which is more precise for detecting ARM64 architecture. This change enhances future compatibility and reduces the risk of false positives for other ARM variants.	8
Best practice	✅ Correct the error message by removing an unnecessary character Suggestion Impact: The suggestion impacted the commit by removing the '=' sign from the error message, although the commit also changed "ARM64" to "ARM". code diff: - throw new WebDriverException("Linux ARM64= is not supported by Selenium Manager"); + throw new WebDriverException("Linux ARM is not supported by Selenium Manager"); Remove the '=' sign from the error message as it appears to be a typo and doesn't add any meaningful information. java/src/org/openqa/selenium/manager/SeleniumManager.java [198] -throw new WebDriverException("Linux ARM64= is not supported by Selenium Manager"); +throw new WebDriverException("Linux ARM64 is not supported by Selenium Manager"); Apply this suggestion Suggestion importance[1-10]: 7 Why: Removing the '=' sign from the error message corrects a likely typo, improving the clarity and professionalism of the message without altering functionality.	7
Best practice	Enhance error handling by adding a warning log before throwing an exception Consider logging a warning message before throwing the exception to provide more context about the unsupported architecture. java/src/org/openqa/selenium/manager/SeleniumManager.java [197-201] if (System.getProperty("os.arch").contains("arm")) { - throw new WebDriverException("Linux ARM64= is not supported by Selenium Manager"); + LOG.warning("Detected unsupported Linux ARM architecture"); + throw new WebDriverException("Linux ARM64 is not supported by Selenium Manager"); } else { folder = "linux"; } Apply this suggestion Suggestion importance[1-10]: 6 Why: Adding a warning log provides additional context before an exception is thrown, which can be useful for debugging and understanding the cause of the error. However, it is a minor enhancement since the exception message already conveys the issue.	6

💡 Need additional feedback ? start a PR chat

shbenzer · 2024-10-17T21:51:48Z

I think this should be sufficient - but let me know if I misunderstood the decision y'all made in Issue #13793 . Used System.getProperty() instead of current.Is() since ARM is part of the system architecture.

java/src/org/openqa/selenium/manager/SeleniumManager.java

shbenzer · 2024-10-23T14:49:25Z

the weird git diff error in the workflow should be fixed now - for some reason the linux word got removed, I put it back

A1exKH

LGTM.

shbenzer · 2024-11-06T15:45:11Z

@pujagani Failing test is unrelated:

java.lang.Exception: org.openqa.selenium.JavascriptEnabledDriverTest.testShouldBeAbleToFindElementAfterJavascriptCausesANewPageToLoad is not yet expected to work on remote builds using CHROME, but it already works!
at org.openqa.selenium.testing.SeleniumExtension.afterEach(SeleniumExtension.java:160)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

shbenzer · 2024-11-06T18:37:50Z

looks like the same test is failing @pujagani

java.lang.Exception: org.openqa.selenium.JavascriptEnabledDriverTest.testShouldBeAbleToFindElementAfterJavascriptCausesANewPageToLoad is not yet expected to work on remote builds using CHROME, but it already works!

Seems like a good thing though?

pujagani · 2024-11-07T03:59:39Z

Yes, the test is not a concern. Thank you @shbenzer!

mkurz · 2025-10-04T23:43:41Z

java/src/org/openqa/selenium/manager/SeleniumManager.java

          folder = "macos";
        } else if (current.is(LINUX)) {
-          folder = "linux";
+          if (System.getProperty("os.arch").contains("arm")) {


You should also check for aarch64, see

[java] Linux ARM "os.arch" system property is "aarch64" #16381

Create an issue and we’d be happy to take a look - commenting here will cause us to miss or forget @mkurz

I referenced the PR I created. I just wanted to make the author of the PR aware that the check was not enough. (Also for readers who stumple on this issue later)

Ah, I see - I didn't understand the link clearly on my phone. Thank you!

shbenzer and others added 2 commits October 17, 2024 17:49

Throw Error When Using Unsupported Linux ARM

25e3bfe

Merge branch 'trunk' into issue-13793

378328a

qodo-merge-pro bot added P-bug fix PR addresses a known issue Review effort [1-5]: 2 labels Oct 17, 2024

Update SeleniumManager.java

eddc986

AutomatedTester reviewed Oct 18, 2024

View reviewed changes

java/src/org/openqa/selenium/manager/SeleniumManager.java Outdated Show resolved Hide resolved

shbenzer added 3 commits October 18, 2024 10:01

fixed formatting

04f04c5

Merge branch 'trunk' into issue-13793

d965ca5

Merge branch 'trunk' into issue-13793

c69505f

shbenzer requested a review from AutomatedTester October 22, 2024 17:29

shbenzer added 5 commits October 22, 2024 15:13

fixed formatting - my bad

a7be622

Update SeleniumManager.java

cb89f97

Update SeleniumManager.java

37cd813

Merge branch 'trunk' into issue-13793

c853c84

Update SeleniumManager.java

bbe46a1

A1exKH reviewed Oct 23, 2024

View reviewed changes

shbenzer and others added 5 commits October 25, 2024 18:02

Merge branch 'trunk' into issue-13793

8a000fd

Merge branch 'trunk' into issue-13793

40a0b7d

Merge branch 'trunk' into issue-13793

cd16d30

Merge branch 'trunk' into issue-13793

efa1e18

Merge branch 'trunk' into issue-13793

99468b5

pujagani approved these changes Nov 7, 2024

View reviewed changes

Merge branch 'trunk' into issue-13793

197f1e7

VietND96 merged commit 0a9d689 into SeleniumHQ:trunk Nov 8, 2024
31 checks passed

bonigarcia mentioned this pull request Dec 12, 2024

[🐛 Bug]: Selenium Manager downloads x86_64 firefox binaries on ARM Linux #13793

Closed

shbenzer deleted the issue-13793 branch January 16, 2025 00:38

dependabot bot mentioned this pull request Sep 18, 2025

Bump the selenium group with 2 updates 7474/SRC#677

Merged

dependabot bot mentioned this pull request Oct 1, 2025

Bump Selenium.Support and Selenium.WebDriver rajbos/github-azure-devops-marketplace-extension-news#277

Closed

mkurz reviewed Oct 4, 2025

View reviewed changes

dependabot bot mentioned this pull request Oct 24, 2025

Bump Selenium.WebDriver from 4.7.0 to 4.37.0 javiertuya/selema#945

Closed

Uh oh!

Throw Error When Using Unsupported Linux ARM #14616

Throw Error When Using Unsupported Linux ARM #14616

Uh oh!

Conversation

shbenzer commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

Description

Motivation and Context

Types of changes

Checklist

PR Type

Description

Changes walkthrough 📝

Uh oh!

qodo-merge-pro bot commented Oct 17, 2024

PR Reviewer Guide 🔍

Uh oh!

qodo-merge-pro bot commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Code Suggestions ✨

Uh oh!

shbenzer commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

shbenzer commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

A1exKH left a comment

Choose a reason for hiding this comment

Uh oh!

shbenzer commented Nov 6, 2024

Uh oh!

shbenzer commented Nov 6, 2024

Uh oh!

pujagani commented Nov 7, 2024

Uh oh!

Uh oh!

mkurz Oct 4, 2025

Choose a reason for hiding this comment

Uh oh!

shbenzer Oct 4, 2025

Choose a reason for hiding this comment

Uh oh!

mkurz Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shbenzer Oct 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shbenzer commented Oct 17, 2024 •

edited

Loading

qodo-merge-pro bot commented Oct 17, 2024 •

edited

Loading

shbenzer commented Oct 17, 2024 •

edited

Loading

shbenzer commented Oct 23, 2024 •

edited

Loading

mkurz Oct 4, 2025 •

edited

Loading